Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify minimun version of npm to run command in subproject #2728

Merged

Conversation

cuichenli
Copy link
Contributor

Signed-off-by: Cuichen Li [email protected]

Which problem is this PR solving?

The CONTRIBUTING document did not specify clearly the minimum version of npm and I am getting errors when trying to run lint in subprojects says can not find eslint. Turns out I was using [email protected], which does not have the algorithm to find binary in parent node_modules. By upgrading it to at least 7.x can fix the issue.

This may be one edge case (I do not know how many people are still using this version nowadays). But by using nvm to install node14 we would get [email protected].

@cuichenli cuichenli requested a review from a team January 21, 2022 04:04
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #2728 (edfd205) into main (ed043be) will not change coverage.
The diff coverage is n/a.

❗ Current head edfd205 differs from pull request most recent head 9d7783e. Consider uploading reports for the commit 9d7783e to get more accurate results

@@           Coverage Diff           @@
##             main    #2728   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         159      159           
  Lines        5445     5445           
  Branches     1143     1143           
=======================================
  Hits         5079     5079           
  Misses        366      366           

@dyladan
Copy link
Member

dyladan commented Jan 21, 2022

I have not had this issue with npm 6

@dyladan
Copy link
Member

dyladan commented Jan 21, 2022

ah i see when you run from directly within the directory

@vmarchaud vmarchaud added the document Documentation-related label Jan 23, 2022
@legendecas legendecas merged commit 4f8849f into open-telemetry:main Feb 9, 2022
@legendecas
Copy link
Member

Thank you for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants